sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land.
a few docs improvements proposed, otherwise, it looks clean, clear and simple. INLINE COMMENTS > plasmashell.h:293 > + /** > + * Requests to hide a surface with Role Panel and PanelBahvior AutoHide. > + * Behavior (typo) > plasmashell.h:306 > + /** > + * Emitted when the compositor hided an auto hiding panel. > + * @see requestHideAutoHidingPanel past tense of hide is "hid" > plasmashell.h:314 > + /** > + * Emitted when the compositor showed an auto hiding panel. > + * @see requestHideAutoHidingPanel "showed" is a bit ambiguous here, as that *could* mean it's not shown anymore. Maybe just make it clear that the signal is emitted after the show panel animation is finished? > plasma-shell.xml:350 > + The compositor will restore the visibility state of the > + surface when the pointer touches the screen edge the panel > borders. Once the compositor restores > + the visibility the event auto_hidden_panel_shown will be sent. > This event will also be sent screen edge *or* panel borders > plasma-shell.xml:351 > + surface when the pointer touches the screen edge the panel > borders. Once the compositor restores > + the visibility the event auto_hidden_panel_shown will be sent. > This event will also be sent > + if the compositor is unable to hide the panel. visibility*,* REPOSITORY rKWAYLAND KWayland BRANCH panel-auto-hide REVISION DETAIL https://phabricator.kde.org/D3007 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, sebas Cc: sebas, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts
