hein added a comment.
Here's a few spontaneous thoughts ... not really meant as an in-depth review: - This is like a step 1, right? It appears the requestAdd/Remove APIs currently add/remove to all activities, so there's no way yet for users to make per-activity launchers? - I'm a bit surprised that the code doesn't use the existing machinery to filter the launcher list by activity ... couldn't LauncherTasksModel just implement AbstractTasksModel::AdditionalRoles::Activities for launcher tasks and rely on TaskFilterProxyModel doing the rest, just like it works for window tasks? The "shownLauncherList" stuff seems to reinvent the wheel at the lower level, when the overall approach in the libtaskmanager codebase is to have a pyramid of dumb list source models that get increasingly filtered/mangled. Or did you try this and it ran into trouble with the ordering ...? - Note that there shouldn't be any magic that only makes sense in concert with the specific TM applet, the libtaskmanager API should make sense to someone coming at it cold and obey its users. It has users outside of the TM applet. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3005 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, #plasma, hein Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
