davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> pritambaral wrote in SessionManagementScreen.qml:89-90
> It isn't. `Layout.alignment` controls alignment of the Label element, 
> `horizontalAlignment` controls alignment of the //text within// the Label 
> element.
> 
> I could replace `Layout.alignment: Qt.AlignHCenter` with 
> `anchors.horizontalCenter: parent.horizontalCenter`; they have the same 
> effect.

Oh, because even though it has fillWidth: true we still have a 
Layout.maximumWidth so we do need both.

This is fine.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2984

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: pritambaral, #plasma, davidedmundson
Cc: davidedmundson, jensreuterberg, pritambaral, plasma-devel, lesliezhai, 
ali-mohamed, abetts, sebas

Reply via email to