mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> appletinterface.cpp:663
> +
> +    if (!applet()->containment()) {
> +        return regVal;

even if will never likely happen, just for completenesss, adding a check on 
corona existence here?

> appletinterface.cpp:669
> +    int screenId = screen();
> +    if (screenId > -1 && applet()->containment()->corona()) {
> +        reg = 
> applet()->containment()->corona()->availableScreenRegion(screenId);

so could be removed from here

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2932

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Reply via email to