davidedmundson added inline comments.
INLINE COMMENTS
> KickoffConfigurationButton.qml:30-38
> + width: units.gridUnit * 6
> + height: units.gridUnit * 5
>
> - property alias icon: iconElement.source
> - property alias text: textElement.text
> - property string name
>
> - width: units.gridUnit * 6
> - height: units.gridUnit * 5
> + PlasmaCore.FrameSvgItem {
> + id: container
> + width: units.gridUnit * 6
You should be able to get rid of the Item {} and just use the FrameSvgItem for
the root component
> KickoffConfigurationButton.qml:45
>
> - height: childrenRect.height
> + imagePath: plasmoid.location === PlasmaCore.Types.Vertical ||
> plasmoid.location === PlasmaCore.Types.Horizontal
> + ? "widgets/panel-background" : "widgets/background"
for the tabs the background will always be widgets/background they're not shown
directly on the panel.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2900
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jsalatas, #plasma, #plasma:_design
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas
