----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129057/ -----------------------------------------------------------
(Updated Sept. 28, 2016, 3:41 p.m.) Review request for KDE Frameworks and Plasma. Changes ------- oops Repository: plasma-framework Description ------- I've been looking into what we're actually doing nowadays when we learn about a plasmoid at boot. I realized that we were doing a bit of a roundabout and there's definitely shorter paths. As far as I understood, what we're doing is: 1. We list all plugins and construct their KPluginMetaData 2. We get the metadata file path and send it to corona, that will create a KService::Ptr and then construct a KPluginInfo from it. 3. KPluginInfo in turn parses the file again. Since recently KPluginInfo is parsing the files twice 3.1. using KPluginMetaData 3.2. using KDesktopFileParser This patch, tries to simplify 2 and 3 into a KPluginMetaData construction call. Furthermore, this will allow us eventually (in a separate iteration, and everything works according to the plan) to load plugins from metadata.json which would make it possible to get rid of the internal usage of the desktopfileparser within kcoreaddons. (With something like this https://paste.kde.org/pth9wmasc) Diffs (updated) ----- src/plasma/applet.h 449f761 src/plasma/applet.cpp 5e278dc src/plasma/containment.cpp 803887d src/plasma/private/applet_p.h c3fe1d2 src/plasma/private/applet_p.cpp 0f37fe5 src/plasma/private/storage.cpp 8983128 src/plasma/scripting/appletscript.cpp 42c0395 src/plasmaquick/appletquickitem.cpp 95695d5 src/plasmaquick/configview.cpp b6ef7ac src/scriptengines/qml/plasmoid/appletinterface.cpp 466dbd8 Diff: https://git.reviewboard.kde.org/r/129057/diff/ Testing ------- Tests still pass, plasmashell starts beautifully. Thanks, Aleix Pol Gonzalez
