-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126640/
-----------------------------------------------------------

(Updated Sept. 22, 2016, 8:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for kwin and Plasma.


Repository: plasma-framework


Description
-------

According to [X.org 
docs](http://www.x.org/releases/X11R7.7/doc/compositeproto/compositeproto.txt) 
regarding NameWindowPixmap:

"This pixmap will remain allocated until freed, even if 'window' is unmapped, 
reconfigured or destroyed. However, 'window' will get a new pixmap allocated 
each time it is mapped or resized, so this request will need to be reinvoked"

So, pixmap needs to be discarded not only on XCB_CONFIGURE_NOTIFY event but on 
XCB_MAP_NOTIFY event also.


Diffs
-----

  src/declarativeimports/core/windowthumbnail.cpp 21e655e 

Diff: https://git.reviewboard.kde.org/r/126640/diff/


Testing
-------

Tested by using simple qml app with WindowThumbnail and minimizing\unminimizing 
of corresponding window. Now after unminimizing pixmap is still valid and live 
updating works.


Thanks,

Mihail Ivchenko

Reply via email to