----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118697/ -----------------------------------------------------------
(Updated Sept. 22, 2016, 8:40 p.m.) Status ------ This change has been discarded. Review request for Plasma. Repository: plasma-mediacenter Description ------- This one has been pending for some time now. Our Album data model assumed that a album name is enough to uniquely identify an album. This creates problems because multiple artists may have albums with the same name. This patch makes Media Library and ItemCache aware of this fact. Diffs ----- libs/mediacenter/album.h 4926e48 libs/mediacenter/album.cpp 881f65a libs/mediacenter/itemcache.h ffee05f libs/mediacenter/medialibrary.cpp 9c58b44 libs/test/itemcachetest.h 4fc6807 libs/test/itemcachetest.cpp e6dee33 libs/test/medialibrarytest.h 718457d libs/test/medialibrarytest.cpp e1a8c9b libs/test/mediatest.cpp 8fde60b libs/test/pmcalbumtest.cpp 9f2b4c8 Diff: https://git.reviewboard.kde.org/r/118697/diff/ Testing ------- Unit tests pass. Added test to take care of the new scenario. Thanks, Shantanu Tushar
