----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110122/#review99459 -----------------------------------------------------------
Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On April 25, 2013, 1:58 p.m., James Pike wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/110122/ > ----------------------------------------------------------- > > (Updated April 25, 2013, 1:58 p.m.) > > > Review request for Plasma. > > > Bugs: 318295 > http://bugs.kde.org/show_bug.cgi?id=318295 > > > Repository: kde-workspace > > > Description > ------- > > Currently the timeout of the last notification to arrive is used as a basis > for hiding the notification display. This means that a notification with a > high timeout can get hidden by a new notification arriving with a much lower > timeout. > > This patch simply changes the behaviour to, when expiring a timer, go back > through the stack and display the most recent unexpired timer. If all timers > are expired the notification is closed as before. > > > Diffs > ----- > > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml > 2fa1b11 > > Diff: https://git.reviewboard.kde.org/r/110122/diff/ > > > Testing > ------- > > Test script in https://bugs.kde.org/show_bug.cgi?id=318295 > > > Thanks, > > James Pike > >