> On Септ. 22, 2016, 2:42 преди обяд, David Edmundson wrote: > > appmenu/appmenu.cpp, line 90 > > <https://git.reviewboard.kde.org/r/128997/diff/1/?file=477301#file477301line90> > > > > what's with this change? > > Aleix Pol Gonzalez wrote: > The warning was saying that it's a delete of something fwd-declared. A > bit more research suggested that it's `#if 0`'d everywhere else. So here too.
At line 32 topmenu is removed as include. Deleting pointer of fwrd declared class is a no-op, you can get rid of m_menubar usage at all. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128997/#review99402 ----------------------------------------------------------- On Септ. 22, 2016, 2:36 преди обяд, Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128997/ > ----------------------------------------------------------- > > (Updated Септ. 22, 2016, 2:36 преди обяд) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Should be ok, would like your +1 nevertheless. > > > Diffs > ----- > > applets/digital-clock/plugin/timezonemodel.cpp efd4eb2 > applets/notifications/plugin/notificationshelper.h 066048e > appmenu/appmenu.cpp bb2e7f5 > components/shellprivate/interactiveconsole/interactiveconsole.cpp 12f0bb0 > components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels.cpp > 2560d5d > components/shellprivate/widgetexplorer/widgetexplorer.cpp be5c9dc > dataengines/apps/appsengine.cpp 81e8ce5 > dataengines/geolocation/geolocation.cpp 38e106c > dataengines/share/shareengine.cpp 039777d > dataengines/weather/ions/noaa/ion_noaa.cpp 40dcd46 > drkonqi/parser/backtraceparser.h 9728e20 > klipper/clipcommandprocess.cpp b6631b5 > klipper/editactiondialog.cpp afd7d3e > klipper/klipper.cpp 525ef87 > krunner/dialog.h a34152a > kuiserver/progresslistdelegate.h 0fa3d6f > libtaskmanager/abstracttasksmodel.h cb6e74f > libtaskmanager/abstracttasksproxymodeliface.h 4c627f1 > libtaskmanager/activityinfo.cpp 8427cfd > libtaskmanager/flattentaskgroupsproxymodel.cpp 8b02d57 > libtaskmanager/taskfilterproxymodel.cpp b2cd2b1 > libtaskmanager/tasksmodel.h 1a7eb2c > libtaskmanager/waylandtasksmodel.cpp 458a0c8 > plasma-windowed/main.cpp de3dff8 > runners/bookmarks/browsers/chrome.cpp 9d5e6e9 > runners/bookmarks/browsers/chromefindprofile.cpp 925083a > runners/bookmarks/faviconfromblob.cpp 77512eb > runners/kill/killrunner.cpp a7a7a01 > runners/shell/shellrunner.h 29d5d3c > runners/webshortcuts/webshortcutrunner.cpp 1ad6677 > shell/alternativeshelper.cpp a96b266 > shell/containmentconfigview.cpp 3ae2985 > shell/desktopview.h f72add1 > shell/panelview.h 36c414e > shell/scripting/scriptengine_v1.cpp ab33bf5 > shell/shellcorona.cpp 25e0378 > wallpapers/image/backgroundlistmodel.cpp 8130b1c > wallpapers/image/image.h c488a84 > wallpapers/image/image.cpp ea66733 > > Diff: https://git.reviewboard.kde.org/r/128997/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
