broulik created this revision. broulik added reviewers: Plasma, sitter. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY It does X calls and might crash kded on logout. Since we already have a currentLayout member, there's no need to get it afresh. BUG: 364340 FIXED-IN: 5.8.0 TEST PLAN Verified that changing the keyboard layout through the tray icon invokes KeyboardDaemon::layoutChanged() where currentLayout is updated. Then kquitapp kded5 and it saved the proper layout. Didn't test whether other means (there's perhaps other ways the layout can change? dunno, it's X.) still work. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2818 AFFECTED FILES kcms/keyboard/keyboard_daemon.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, sitter Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas