davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY Due to a lack of pa_channel_map::&operator==() the code does a memcpy on cached m_channelMap to the new version in the update to see if it needs updating. As our struct starts of uninitialised, vagrlind prints a correct warning about comparing uninitialised data. However, given our garbage data is unlikely to match the update, it's not a bug that has a lot of impact. TEST PLAN valgrind plasmashell is quieter REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D2796 AFFECTED FILES src/streamrestore.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas