zx2c4 created this revision. zx2c4 added a reviewer: mart. zx2c4 added a subscriber: plasma-devel. Restricted Application added a project: Plasma.
REVISION SUMMARY First we remove the fallback code for a version of Xcursor that corresponds with an X server KDE doesn't even support any more. Then we reverse the order of tilde expansion and deduplication, which before was essentially incorrect. Next we do deduplication properly, using Qt's removeDuplicates function. Finally we replace the ugly regex with the helper function in kcoreextras via std::transform. This work here reflects the recent review and discussion that went into the nearly identical code in kde-gtk-kcm. TEST PLAN Observe that cursors are correctly populated. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2772 AFFECTED FILES kcms/cursortheme/xcursor/thememodel.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: zx2c4, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
