broulik added inline comments.
INLINE COMMENTS
> systemtray.cpp:386
> QMap<QString, KPluginInfo> sortedApplets;
> - foreach (const KPluginInfo &info, applets) {
> - const QString dbusactivation =
> info.property(QStringLiteral("X-Plasma-DBusActivationService")).toString();
> - if (!dbusactivation.isEmpty()) {
> - qCDebug(SYSTEM_TRAY) << "ST Found DBus-able Applet: " <<
> info.pluginName() << dbusactivation;
> - m_dbusActivatableTasks[info.pluginName()] = dbusactivation;
> - continue;
> - }
> -
> - if (m_allowedPlasmoids.contains(info.pluginName()) &&
> + foreach (const KPluginInfo &info, m_systrayApplets.values()) {
> + if (m_allowedPlasmoids.contains(info.pluginName()) && !
Don't iterate over values(), you're creating a temporary QList just to iterate
over it:
for (auto it = m_systrayApplets.constBegin(); end =
m_systrayAppltes.constEnd(); it != end; ++it) {
const KPluginInfo &info = it.value();
...
}
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2756
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas
