graesslin added inline comments. INLINE COMMENTS
> sebas wrote in options.h:193 > without the is* ? (It's not required by QML, unlike Thomas suggests) Using is in the case of boolean getters is normally correct. This follows the property naming suggestions by Qt. Please see https://doc.qt.io/archives/qq/qq13-apis.html#theartofnaming and also the examples in https://doc.qt.io/qt-5/properties.html - in this specific case the wording should be changed to windowsBlockCompositing REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2584 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, #vdg Cc: sebas, broulik, colomar, luebking, mart, bshah, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts
