broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rKSCREENLOCKER KScreenLocker. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY This cleans up the UI by moving the wallpaper configuration to a separate tab and also gives it more room. It uses a documentMode TabWidget (no frame) as it has a lighter color and I couldn't find an equivalent in QPalette to make QQuickWidet blend in there. Also take into account QtQuick Layouts hardcoded default spacing of 5px to make ComboBoxes aligned. TEST PLAN Just shuffled widgets around, still works. Wallpaper config expands to full dialog height now :) While at it added a colon to the "lock screen on resume" label Doc about hardcoded spacing: https://doc.qt.io/qt-5/qml-qtquick-layouts-rowlayout.html#spacing-prop F326792: Screenshot_20160912_174456.png <https://phabricator.kde.org/F326792> F326793: Screenshot_20160912_174534.png <https://phabricator.kde.org/F326793> REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D2753 AFFECTED FILES kcm/kcm.cpp kcm/kcm.ui EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
