graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland.
REVISION SUMMARY According to the Wayland documentation a data source needs to be cancelled whenever it is no longer valid. A reason for no longer being valid is that the data source has been replaced by another data source. So far KWayland did not implement this aspect which resulted in clipboard breaking in QtWayland applications. As soon as one copied once from an application it was no longer possible to paste to it from another application. With this change the data source gets properly cancelled and also ensured that the server code doesn't run into a possible crash condition when trying to cancel an already unbound data source. BUG: 368391 REPOSITORY rKWAYLAND KWayland BRANCH cancel-data-source REVISION DETAIL https://phabricator.kde.org/D2743 AFFECTED FILES autotests/client/test_datadevice.cpp src/server/datadevice_interface.cpp src/server/datasource_interface.cpp src/server/seat_interface.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas