broulik created this revision.
broulik added reviewers: Plasma, dfaure.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This brings back the properties dialog allowing to manipulate the icon and 
label of a widget.

TEST PLAN
  It's pretty broken right now.
  Basically it makes sure we always have a desktop file which we can edit 
(either copying the one of the app or making a Link one in case of files). (the 
plasma 4 applet did some mental stuff with creating a desktp file only if you 
edited it and it wasnt writable etc etc). I made sure though that existing 
applets (plasma 5.7) will be gracefully migrated by creating a desktop file on 
first launch.
  Due to some kio bug the editing of desktop file doesnt actually work.
  Also launching it is broken as a I cant figure out a KRun call that actually 
work with both desktop files (app or Link)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2687

AFFECTED FILES
  applets/icon/CMakeLists.txt
  applets/icon/iconapplet.cpp
  applets/icon/iconapplet.h
  applets/icon/package/contents/config/main.xml
  applets/icon/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Reply via email to