mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > GlobalDrawer.qml:99 > + */ > + property real ratio: 16/9 > + for me exporting a ratio property looks a bit weird, i would prefer directly exporting as alias the source size f the image, maybe just as bannerSourceSize REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2593 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel