graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY So far this connect was only in ShellClient, but it's needed for all Toplevels. Also when a XWayland window has it's surface size changed, the pixmap needs to be discarded. Otherwise KWin might hit an assert in AbstractEGLTexture due to the buffer having a different size than the texture had previously. TEST PLAN Firefox, click download on bugreports.qt.io used to trigger this for me. With this change no longer able to reproduce. REPOSITORY rKWIN KWin BRANCH discard-window-pixmap-surface-size-changed REVISION DETAIL https://phabricator.kde.org/D2583 AFFECTED FILES shell_client.cpp toplevel.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas