----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128761/#review98668 -----------------------------------------------------------
kstyle/oxygenstyleplugin.cpp (line 44) <https://git.reviewboard.kde.org/r/128761/#comment66462> This must be not (!inited). However this is not proper fix. Correct and test patch in this way QPointer<Qstyle> style = new Style; Below unchanged, so when QPointer got delete it hold nullptr by itself and delete will be safe. - Anthony Fieroni On Авг. 26, 2016, 1:07 преди обяд, Peter Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128761/ > ----------------------------------------------------------- > > (Updated Авг. 26, 2016, 1:07 преди обяд) > > > Review request for Plasma, David Edmundson, David Faure, and Hugo Pereira Da > Costa. > > > Bugs: 356940 > https://bugs.kde.org/show_bug.cgi?id=356940 > > > Repository: oxygen > > > Description > ------- > > Do not delete all style instances which we create, restrict ourselves to > the first instance. I have no idea if the delete hack is still needed, > but let's keep it until it is certain that it is unneeded. > > Copied from breeze patch https://git.reviewboard.kde.org/r/128760/ > > > Diffs > ----- > > kstyle/oxygenstyleplugin.cpp 70b90d9 > > Diff: https://git.reviewboard.kde.org/r/128761/diff/ > > > Testing > ------- > > Started `QT_STYLE_OVERRIDE=oxygen LD_LIBRARY_PATH=... QT_PLUGIN_PATH=... > wireshark -o` (an invalid option that triggers `exit(1)`) and observe a > heap-use-after free similar to the one reported in the bug. Apply this patch, > rebuild oxygen and notice that the crash is fixed. > > > Thanks, > > Peter Wu > >
