broulik added a comment.

  Don't you need plasma core for units? I thought we didn't want to pull that 
in for startup time of the splash.

INLINE COMMENTS

> Splash.qml:46
> +            property int gridUnit: boundingRect.height
> +            property int largeSpacing: units.largeSpacing
> +            property int smallSpacing: Math.max(2, gridUnit/4)

This doesn't make sense, you bind the thing to itself.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2515

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Reply via email to