----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128726/#review98523 -----------------------------------------------------------
As the maintainer of both klipper and kglobalaccel I'm strictly against ading this shortcut by default! This was already stated by me in the bug report by setting it to wontfix. At the moment this would result in a hidden default shortcut no user knows about. This is bad, we should not add unexepected and unknown shortcuts. And we should not needlessly steal shortcuts from applications. In doubt don't set a shortcut by default. At the current time this would only result in a degrated user experience: either an in-application shortcut, which we don't know that it existed, started to break, or the user presses the shortcut and gets hit by surprise what happens. It's totally unexpected behavior to open this menu. Before we start to add new shortcuts, we need to rethink and implement better ways of global shortcut handling: 1. educating users about shortcuts 2. ensuring that we don't steal shortcuts (e.g. by setting up a policy about which modifier belongs to the DE) As long as these problems are not solved, I'm strictly against adding shortcuts for hidden functionality. No matter how much we personally think they are sensible. - Martin Gräßlin On Aug. 21, 2016, 2:47 a.m., Andreas Kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128726/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2016, 2:47 a.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > ------- > > add a default shortcut for open clipboard at mouse point (ctrl+alt+c) > > BUG 366690 > > > Diffs > ----- > > klipper/klipper.cpp 525ef87 > > Diff: https://git.reviewboard.kde.org/r/128726/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Kainz > >
