----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128616/ -----------------------------------------------------------
(Updated Aug. 20, 2016, 3:31 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks, Plasma and Marco Martin. Changes ------- Submitted with commit 4bf1ef7ea6b30a37170ded7bdb3ac826b87a9b94 by Friedrich W. H. Kossebau to branch master. Repository: plasma-framework Description ------- plasma-dataengine.desktop misses at least the definition of "X-KDE-ParentApp" property. plasma-applet.desktop defines a "X-Plasma-ParentApp" property, but in code and API dox the respective key used is named "X-KDE-ParentApp". E.g. `kcoreaddons_desktop_to_json` used with `SERVICE_TYPES` `plasma-dataengine.desktop` or `plasma-applet.desktop` complains about that for desktop files with such entries. While looking at that property, the related API dox of `Plasma::PluginLoader` has lots of copy&paste errors (talks about "applets" when dataengines, containments, etc. are meant). Also inconsistent use of "applets" vs. "Applets", "dataengines" vs. "DataEngines", etc. This patch also cleans that up (separate commit). Diffs ----- src/plasma/data/servicetypes/plasma-applet.desktop e142552 src/plasma/data/servicetypes/plasma-dataengine.desktop 9280645 src/plasma/pluginloader.h 80cd1e9 Diff: https://git.reviewboard.kde.org/r/128616/diff/ Testing ------- Thanks, Friedrich W. H. Kossebau
