davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> lnflogic.cpp:92
> emit messageRequested(ErrorLevel::Error, i18n("Cannot retrieve
> the current Plasma layout."));
> + delete watcher;
> return;
watcher->deleteLater();
because:
1. you should never delete a QObject in a slot. You crash if something else is
connected to the same signal
2. you only need one line then at the top. Otherwise you crash if used after
free.
REPOSITORY
rPLASMASDK Plasma SDK
REVISION DETAIL
https://phabricator.kde.org/D2449
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas
