graesslin requested changes to this revision.
graesslin added a reviewer: graesslin.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> LockScreen.qml:32
> property UserSelect userSelect: null
> - property int interfaceVersion:
> org_kde_plasma_screenlocker_greeter_interfaceVersion ?
> org_kde_plasma_screenlocker_greeter_interfaceVersion : 0
> - signal clearPassword()
> + property int interfaceVersion:
> org_kde_plasma_screenlocker_greeter_interfaceVersion
>
this change I don't understand. It's not described in the change.
> LockScreen.qml:59-63
> - Component.onCompleted: {
> - if (root.interfaceVersion < 2) {
> - mainLoader.source = "LockScreenUi.qml";
> - }
> - }
why is that removed?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2462
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas
