----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128603/#review98120 -----------------------------------------------------------
Fix it, then Ship it! src/kpackagetool/kpackagetool.cpp (line 439) <https://git.reviewboard.kde.org/r/128603/#comment66083> if () { } - Marco Martin On Aug. 4, 2016, 5:30 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128603/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 5:30 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kpackage > > > Description > ------- > > In general, KPackage plugins should work anywhere the > KPackage::PackageStructure has been designed to support. > Use the metadata from the PackageStructure to know what's the ParentApp. Let > the plugin override the value. > > > Diffs > ----- > > src/kpackagetool/kpackagetool.cpp 422f831 > > Diff: https://git.reviewboard.kde.org/r/128603/diff/ > > > Testing > ------- > > All components in plasma-workspace and plasma-desktop are addons now, after > modifying locally the packagestructure metadata files. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
