bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land.
Apart from d_ed's comment looks good, perhaps you can change to ecm macro in different revision... REPOSITORY rKSCREEN KScreen BRANCH sebas/kcmcatlogging REVISION DETAIL https://phabricator.kde.org/D2294 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma, bshah Cc: bshah, davidedmundson, plasma-devel, ali-mohamed, jensreuterberg, abetts, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
