davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Ship it.
INLINE COMMENTS
> panelview.cpp:1043
>
> void PanelView::screenDestroyed(QObject* )
> {
we can just kill this entire method
> panelview.h:89
> */
> - Q_PROPERTY(QScreen *screen READ screen WRITE setScreen NOTIFY
> screenChangedProxy)
> + Q_PROPERTY(QScreen *screen READ screenToFollow WRITE setScreenToFollow
> NOTIFY screenToFollowChanged)
>
I think even though it means a change in plasma-desktop, we should change this
property name.
We were previously shadowing an existing property, but doing a hack to also
expose a write method.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
mart/screenConnectorManagement
REVISION DETAIL
https://phabricator.kde.org/D2218
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, davidedmundson
Cc: lbeltrame, davidedmundson, rwooninck, graesslin, plasma-devel,
jensreuterberg, abetts, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
