graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> test_plasma_window_model.cpp:446-447
> +{
> + auto model = m_pw->createWindowModel();
> + QVERIFY(model);
> +
you don't need to create a model. You have one in m_pw
> test_plasma_window_model.cpp:460-461
> +
> + m_connection->flush();
> + m_display->dispatchEvents();
> +
those two should not be needed.
> test_plasma_window_model.cpp:466
> +
> + const QRect geom(0, 0, 50, 50);
> + w->setGeometry(geom);
could you use different values? E.g. if we swapped width and height, we
wouldn't notice.
REPOSITORY
rKWAYLAND KWayland
REVISION DETAIL
https://phabricator.kde.org/D2203
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma, graesslin
Cc: plasma-devel, jensreuterberg, abetts, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
