graesslin added inline comments.

INLINE COMMENTS

> kcm_kscreen.cpp:154
> +
> +    QTimer::singleShot(1000, this,
> +        [this] () {

I don't really like the "magic" 1000 here. It would be nicer to have a proper 
way to detect it. But better than before.

Please add a comment that this is a hack and how you got the 1sec.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2154

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: graesslin, plasma-devel, jensreuterberg, abetts, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to