drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land.
Please fix that last style issue and push, thanks! INLINE COMMENTS > modulemanager.h:42 > +public: > + ModuleManager(QObject *parent=nullptr); > + ~ModuleManager(); This needs spaces around = `*parent = nullptr` REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH qgconf REVISION DETAIL https://phabricator.kde.org/D2073 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, drosca Cc: drosca, broulik, plasma-devel, jensreuterberg, abetts, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel