sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.
Some suggestions inline, but nothing major.
INLINE COMMENTS
> registry.h:818
> + /**
> + * Creates a XdgShell and sets it up to manage the interface identified
> by
> + * @p name and @p version.
Creates a*n* XdgShell [...]
> xdgshell.h:322
> + /**
> + * The compositor send a configure with the new @p size and the @p
> states.
> + * Before the next commit of the surface the @p serial needs to be
> passed to ackConfigure.
sent
> xdgshell.h:365
> + /**
> + * @returns @c true if managing a xdg_popup.
> + **/
an
> xdgshell_v5.cpp:320
> + bool isValid() const override;
> + operator xdg_popup*() override{
> + return xdgpopupv5;
whitespace before {
> xdgshell_interface.h:47
> +};
> +
> +class KWAYLANDSERVER_EXPORT XdgShellInterface : public Global
Could use @since 5.25. It's kind of clear from the accessor in Display, but
just looking at this class, it should be clear when it appeared.
> xdgshell_interface.h:123
> + * This tells the Surface the current @p states it is in and the @p size
> it should have.
> + * If @p size has with and height at @c 0, the Surface can choose the
> size.
> + *
with -> width
> xdgshell_interface.h:178
> + /**
> + * Emitted whenever the window class changes.
> + **/
@see windowClass
> xdgshell_interface.h:199
> + * The surface requested a change of maximized state.
> + * @param maximized whether the window wants to be maximized
> + **/
Whether (capitalized)
> xdgshell_interface.h:204
> + * The surface requested a change of fullscreen state
> + * @param fullscreen whether the window wants to be fullscreen
> + * @param output An optional output hint on which the window wants to be
> fullscreen
Whether (caps)
REPOSITORY
rKWAYLAND KWayland
BRANCH
xdg-shell
REVISION DETAIL
https://phabricator.kde.org/D2102
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #plasma_on_wayland, sebas
Cc: sebas, plasma-devel, jensreuterberg, abetts
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
