> On July 12, 2016, 11:58 a.m., Marco Martin wrote: > > does this remove a setting or just descriptive labels? > > Andreas Kainz wrote: > it remove the text of the current local time zone, cause therefore you > select it in the list. > > Marco Martin wrote: > hmm, i'm not sure removing the current timezone is useful, when you open > the kcm is indeed redundant as you see the current one selected in the list, > but if you scroll it randomly you can lose it and is not clear anymore what > the current one is. > > Andreas Kainz wrote: > as in all other kcm's you select something and "forget" what was selected > before. as fare as I know the reset button is used for this.
if you just scroll, without selecting something else, the reset button doesn't get enabled - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128372/#review97314 ----------------------------------------------------------- On July 12, 2016, 2:05 a.m., Andreas Kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128372/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 2:05 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > in the kcm date and time -> timezone tab you have a description what you > select in the list and than what was selected now. when you start the kcm, > than you see the selected item so you know what it is now and can say. the > setting is wrong I'd like to change, but when you want to change it, you > don't need to know what it is now cause it is wrong otherwise you wouldn't > change it and in any other kcm you don't get the information what was > selected before you change it. > > > Diffs > ----- > > kcms/dateandtime/dateandtime.ui 1a2a308 > > Diff: https://git.reviewboard.kde.org/r/128372/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > layout now > > https://git.reviewboard.kde.org/media/uploaded/files/2016/07/04/52c342cc-469e-452f-a2e4-b38d11bb23aa__dateandtime.png > 0001-Fix-build.patch > > https://git.reviewboard.kde.org/media/uploaded/files/2016/07/12/fec555a9-c206-48f3-a57d-46bbc578f4c1__0001-Fix-build.patch > > > Thanks, > > Andreas Kainz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
