----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128426/#review97299 -----------------------------------------------------------
Looks like an interesting optimization oportunity! :) src/declarativeimports/core/fadingnode.cpp (line 67) <https://git.reviewboard.kde.org/r/128426/#comment65692> use `switch`? - Aleix Pol Gonzalez On July 12, 2016, 1:34 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128426/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 1:34 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Qt has two shaders for all items; one for when running OpenGL3.2+ without > backwards compatibility (i.e running CoreProfile) and one that supports more > legacy systems. (see > the shaders directory and the versions ending with _core) > > core profile is only used if explicitly by the app enabled when creating the > GL context. > > Something we don't currently do in Plasma, but a 3d party user could be doing. > > Long term it's also something I want to do in Plasma optionally as it gives a > 15Mb memory saving with Mesa. > > This patch updates our material to provide the right shader for the > given version matching the behavior of > QSGShaderSourceBuilder::resolveShaderPath which Qt uses internally. > > > Diffs > ----- > > src/declarativeimports/core/fadingnode.cpp > 88b7310641f58c2b74fe61d2c5a97847cf7dc3b8 > > Diff: https://git.reviewboard.kde.org/r/128426/diff/ > > > Testing > ------- > > ran krunner with > + QSurfaceFormat format; > + format.setVersion(3,2); > + format.setProfile(QSurfaceFormat::CoreProfile); > + QSurfaceFormat::setDefaultFormat(format); > > and it still works. > > plasmashell unchanged (so still requesting an GL 2.0 context) also still > works. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
