broulik created this revision.
broulik added reviewers: Plasma, sitter.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This ensures the logout dialog is kept in memory and continues to work even 
after a Qt or other library update.
  
  BUG: 364897

TEST PLAN
  Mostly works. I logged in and then screwed up my logout dialog QML file and 
still got a shutdown dialog.
  
  We need to adjust the logout dialog QML though so it stops the timer when not 
visible (my root.visible approach didn't work) and resets the timeout. Also it 
doesn't seem to properly update the selected shutdown type, ie. if I select 
Logout and then select Shutdown it doesn't notice. Ideally, we'll just do that 
when we're re-designing the logout dialog anyway.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2044

AFFECTED FILES
  ksmserver/shutdown.cpp
  ksmserver/shutdowndlg.cpp
  ksmserver/shutdowndlg.h
  ksmserver/startup.cpp
  ksmserver/tests/test.cpp
  lookandfeel/contents/components/LogoutScreen.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, sitter
Cc: plasma-devel, jensreuterberg, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to