> On June 28, 2016, 1:47 p.m., David Edmundson wrote: > > src/declarativeimports/core/tooltipdialog.cpp, line 122 > > <https://git.reviewboard.kde.org/r/128300/diff/1/?file=470078#file470078line122> > > > > we already have setFlags(Qt::Tooltip) > > > > why is this not enough?
This depends on https://phabricator.kde.org/D2031 Wayland doesn't have a window type "Tooltip". Thus Qt doesn't do anything with the flag. It's just being ignored. We need to manually do this by creating a PlasmaShellSurface, like with all other custom window types we have but Wayland doesn't. Like OSD, Notification, Panel, Dock. By using KWindowSystem it's just the easiest way. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128300/#review96911 ----------------------------------------------------------- On June 28, 2016, 1:43 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128300/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 1:43 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > In order to have support for tooltip window type in Wayland, the > window type NET::Tooltip is also set through KWindowSystem API once > the platform surface is created. > > > Diffs > ----- > > src/declarativeimports/core/tooltipdialog.cpp > 18aa520bf15e1a03eb6a4816e49ab35e2350f8da > > Diff: https://git.reviewboard.kde.org/r/128300/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
