graesslin requested changes to this revision.
graesslin added a reviewer: graesslin.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> xwindowtasksmodel.cpp:785
> for (int i = 0; i < screens.count(); ++i) {
> - if (screens.at(i)->geometry().intersects(info->geometry())) {
> + if
> (screens.at(i)->geometry().contains(info->frameGeometry().center())) {
> return i;
What if the center of the window is not on any screen? Yes that's possible.
KWin's implementation calculates the distance to every screen and uses the
minimal distance as the screen it's on. Relevant methods to look at:
Toplevel::checkScreen (in toplevel.cpp) and Screens::number in screens.cpp
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1925
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, luebking, lbeltrame, #plasma, graesslin
Cc: graesslin, plasma-devel, jensreuterberg, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
