----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128216/#review96615 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On June 16, 2016, 10:06 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128216/ > ----------------------------------------------------------- > > (Updated June 16, 2016, 10:06 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: krunner > > > Description > ------- > > This adds methods taking an iconName instead of a full-fledged QIcon. It > reduces the likelihood of QIcon-related multithreading issues but also > significantly speeds up KRunner by doing the icon lookup only in the view and > only for icons that we actually display. > > > Diffs > ----- > > src/querymatch.h 972ef83 > src/querymatch.cpp 474e3ac > > Diff: https://git.reviewboard.kde.org/r/128216/diff/ > > > Testing > ------- > > Usin krunner feels a billion times faster now (I adjusted all runners to use > the new api where sensible) > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
