> On June 15, 2016, 9:07 a.m., Marco Martin wrote: > > applets/systemmonitor/common/contents/ui/DoublePlotter.qml, line 84 > > <https://git.reviewboard.kde.org/r/128136/diff/1/?file=468083#file468083line84> > > > > this way if the text is too long, it will not wrap. > > > > if you want it right aligned, you should still have anchors.fill:parent > > and have > > horizontalAlignment: Text.AlignRight
didn't work cause I need align top right and when I add horizontalAlignment: Text.AlignRight it don't work on the desktop cause there is verticalAlignment: Text.AlignTop missing but when I add it than it don't work in the panel cause in the panel it should be right centre align. with the code I had it works in the panel and the desktop and an sidebar panel as you can see in the screenshot - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/#review96512 ----------------------------------------------------------- On June 16, 2016, 9:13 a.m., Andreas Kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128136/ > ----------------------------------------------------------- > > (Updated June 16, 2016, 9:13 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > 1. change the minimum size and the min width in the panel > 2. speedLabels are now right align to the label cause you show the number > which is drown on the right part of the diagramm > 3. round to 14 % instead of 14,14 % for cpu load > > still missing: > a. hide the heading if the desktop widget has to less space for the rows > b. better friendlyName for ram, network > c. remove the gray line from the chart (0-line) at least when the applet was > shown on the panel > d. don't show 0 KB/s or 0 B, ... > > shedule > thanks for your review > if you know how I can fix one of the missing things, let me know > tiny improvements when missing stuff is finished. > > > Diffs > ----- > > applets/systemmonitor/common/contents/ui/Applet.qml fffd8e0 > applets/systemmonitor/common/contents/ui/DoublePlotter.qml 738ffbc > applets/systemmonitor/common/contents/ui/SinglePlotter.qml 987fd2c > applets/systemmonitor/cpu/contents/ui/cpu.qml 4ebbf92 > applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml 994336f > > Diff: https://git.reviewboard.kde.org/r/128136/diff/ > > > Testing > ------- > > on the desktop and the panel > > > File Attachments > ---------------- > > screenshot of the result > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/16/4fecb3bc-d540-4358-af1d-342c77b9cfa3__Screenshot_20160616_111131.png > > > Thanks, > > Andreas Kainz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
