sebas added inline comments.

INLINE COMMENTS

> graesslin wrote in xrandroutput.cpp:253
> sure you want to use a QStringList? It looks to me like you wanted to have 
> them as QLatin1Strings for the startsWith check. But that doesn't work when 
> converted to QString. So maybe QVector<QLatin1String>?

This code is copied, I left it as-is, just moved it around.

I'll fix the issues with the existing code separately.

REPOSITORY
  rLIBKSCREEN KScreen Library

BRANCH
  sebas/xrandrtype

REVISION DETAIL
  https://phabricator.kde.org/D1856

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, dvratil
Cc: broulik, graesslin, plasma-devel, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to