dfaure added inline comments.
INLINE COMMENTS
> hein wrote in xwindowtasksmodel.cpp:665
> Why not use the one from line 654?
Oops, didn't see it. I'll adjust the patch.
However this makes me wonder, given this code
if (!data.icon.name().isEmpty()) {
return data.url;
}
do I still need to handle the case where data.icon is set (non-null, but no
name either, i.e. not from a theme, can this happen?)
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1841
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: dfaure, hein
Cc: broulik, plasma-devel, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
