graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> panelview.cpp:593
>  #if HAVE_X11
> -    xcb_connection_t *c = QX11Info::connection();
> -    if (!c) {
> +    if (!QX11Info::isPlatformX11()) {
>          return;

I suggest to move the complete X11 block into the if. So that we can in future 
add an
else if (isWayland())

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1718

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, graesslin, Plasma
Cc: plasma-devel, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to