----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128030/#review95937 -----------------------------------------------------------
Ship it! Hmm ok ... note this will likely never ship though, in the applet ported to the new libtaskmanager the context menu is in QML and I think we've done the last 5.6.x already ... - Eike Hein On May 28, 2016, 12:07 p.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128030/ > ----------------------------------------------------------- > > (Updated May 28, 2016, 12:07 p.m.) > > > Review request for Plasma, David Edmundson and Eike Hein. > > > Bugs: 362713 > https://bugs.kde.org/show_bug.cgi?id=362713 > > > Repository: plasma-workspace > > > Description > ------- > > Window can be close externally and this cause context menu to became dangerous > > > Diffs > ----- > > > Diff: https://git.reviewboard.kde.org/r/128030/diff/ > > > Testing > ------- > > It looks to work, need test from reporters > NB: I don't know why reviewboard reject patch format. (diff cannot be parsed) > > > File Attachments > ---------------- > > backend.patch > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/28/9a414f0b-af7e-4a34-b651-586af7ba298b__backend.patch > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
