----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127918/#review95548 -----------------------------------------------------------
Fix it, then Ship it! Much cleaner indeed ;-) Thanks. kcms/input/mouse.cpp (line 741) <https://git.reviewboard.kde.org/r/127918/#comment64743> copy/paste error, this should be "Mouse". The "KDE" group is the one handled below. kcms/migrationlib/kdelibs4config.h (line 35) <https://git.reviewboard.kde.org/r/127918/#comment64744> simpleConfigGroup.name() could be simplified to sourceGroup :) - David Faure On May 17, 2016, 4:42 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127918/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 4:42 p.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-desktop > > > Description > ------- > > Address David's issues in previous rr's regarding the code. > > > Diffs > ----- > > kcms/componentchooser/componentchooserbrowser.cpp 5795c2b > kcms/componentchooser/componentchooserfilemanager.cpp a04cced > kcms/componentchooser/componentchooserterminal.cpp 36f1296 > kcms/input/mouse.cpp f7d030f > kcms/migrationlib/kdelibs4config.h bb2dca2 > > Diff: https://git.reviewboard.kde.org/r/127918/diff/ > > > Testing > ------- > > Default browser is correctly written in both ~/.kde4/share/config/kdeglobals > and ~/.config/kdeglobals > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
