> On May 6, 2016, 4:08 p.m., David Rosca wrote: > > It will also need > > https://quickgit.kde.org/?p=plasma-workspace.git&a=commit&h=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3 > > in Plasma/5.6 > > Aleix Pol Gonzalez wrote: > No, it's already called by `ShellCorona::loadDefaultLayout()`. > > David Rosca wrote: > Yes, this is inside ShellCorona::loadDefaultLayout(). In Plasma/5.6 the > loadDefaultLayout does not emit startupCompleted (because the above commit is > only in master) and indeed, this patch does not fix it for me with > plasma-workspace 5.6. > > Aleix Pol Gonzalez wrote: > So should I commit this as is and backport the commit below to 5.6?
+1 from me, but it will still be broken with Plasma 5.5. Do we care about it? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127850/#review95241 ----------------------------------------------------------- On May 6, 2016, 3:56 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127850/ > ----------------------------------------------------------- > > (Updated May 6, 2016, 3:56 p.m.) > > > Review request for KDE Frameworks, Plasma and David Rosca. > > > Bugs: 60777 > http://bugs.kde.org/show_bug.cgi?id=60777 > > > Repository: plasma-framework > > > Description > ------- > > Iteration of: https://git.reviewboard.kde.org/r/127848/ > > We either load the existing layout or we load a default one. > > With this, it could be removed from ShellCorona. > > > Diffs > ----- > > src/plasma/corona.cpp 1784516 > > Diff: https://git.reviewboard.kde.org/r/127850/diff/ > > > Testing > ------- > > Tests pass. > PlasmaShell prints completed once both with and without configuration. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
