----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127862/#review95276 -----------------------------------------------------------
Ship it! Ship It! - Kai Uwe Broulik On Mai 7, 2016, 8:13 nachm., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127862/ > ----------------------------------------------------------- > > (Updated Mai 7, 2016, 8:13 nachm.) > > > Review request for Plasma. > > > Repository: kinfocenter > > > Description > ------- > > Otherwise we were effectively relying on Solid's cache for memory > management. > > This led to a problem that QML's QObject wrapper would detect the > Solid::Battery was being deleted on shutdown, and re-evaluate > currentBattery. This would then call BatteryModel.fetch(0) which being > slightly behind would then return an invalid object. > > This ensure items get deleted in the correct order. > > BUG: 350861 > > > Diffs > ----- > > Modules/energy/batterymodel.h c319d197b7cab1bed67151db65193bc5bcb24e2b > Modules/energy/batterymodel.cpp 7eade5498eda18ee0cfccddec70d5900c4eb2c96 > > Diff: https://git.reviewboard.kde.org/r/127862/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
