> On Mai 5, 2016, 8:02 nachm., Kai Uwe Broulik wrote:
> > Switching themes no longer properly updates the highlight color, ie. 
> > switching from Breeze to Honeycomb leaves me with a blue highlight (and 
> > brokenness in task manager with yellow borders around blue items). Then 
> > switching to another theme leaves me with the previous highlight, ie. 
> > yellow in this case no matter the color I chose. Something's broken now.

And also selected text is now black on blue rather than white on blue like 
before and like in widgets applications


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127842/#review95212
-----------------------------------------------------------


On Mai 5, 2016, 10:22 vorm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127842/
> -----------------------------------------------------------
> 
> (Updated Mai 5, 2016, 10:22 vorm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> lately the highlight color of plasma became a very washed-out blue, (since it 
> switched to use the global system colors) that was because it actually taken 
> the highlight color (and highlightedText) from the wrong source.
> there is a correct color group in kcolorscheme for that, that is Selection, 
> take those two colors from that (also means highlight and highlightedtext 
> always be the same in all plasma::theme::colorgroups but that's not a problem)
> 
> update test to reflect that
> 
> 
> Diffs
> -----
> 
>   autotests/themetest.cpp ce512a4 
>   src/declarativeimports/core/quicktheme.h ac5e121 
>   src/plasma/private/theme_p.h d2246de 
>   src/plasma/private/theme_p.cpp e6d55c3 
> 
> Diff: https://git.reviewboard.kde.org/r/127842/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to