> On May 6, 2016, 5:39 p.m., Aleix Pol Gonzalez wrote: > > I understand it's a bit complex, but it's also not really acceptable that > > the signal is emitted twice. Let me try to come up with an alternative. > > David Rosca wrote: > Sure, no problem. When running plasmashell from terminal without any > arguments, the startup completed is emitted once. Only with plasmashell > --test it is emitted twice. > > Aleix Pol Gonzalez wrote: > It's emitted twice because the first time it loads an empty corona > configuration file, then it finishes and shellcorona realizes there's no > containments and decides to load the default on its own.
See https://git.reviewboard.kde.org/r/127850/ - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127848/#review95235 ----------------------------------------------------------- On May 6, 2016, 10:23 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127848/ > ----------------------------------------------------------- > > (Updated May 6, 2016, 10:23 a.m.) > > > Review request for Plasma and Aleix Pol Gonzalez. > > > Bugs: 360777 > http://bugs.kde.org/show_bug.cgi?id=360777 > > > Repository: plasma-framework > > > Description > ------- > > importLayout is not called when started from SDDM which results in > startupCompleted not being emitted and splash waiting for timeout. > > This reverts commit 309c64f5e90453c5253baf19e6c01759e8aa6f83. > > > Diffs > ----- > > src/plasma/corona.cpp 1784516 > > Diff: https://git.reviewboard.kde.org/r/127848/diff/ > > > Testing > ------- > > No more splash timeouts. > For plasmashell tests, the startupCompleted is emitted 2 times, so tests run > 4 times too (twice for each startupCompleted signal..). > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
