> On May 6, 2016, 2:09 p.m., Hugo Pereira Da Costa wrote: > > Thanks ! > > I tested it here. Looks fine. > > Although the diff is hard to read, new code looks good. > > > > Hugo
PS: since oxygen does a lot of caching, there actually are many other places also affected by the coverty report. (in liboxygen/oxygenhelper). I'll have a look in there at some point, but if you find time to work on it on your own, don't hesitate :) - Hugo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127837/#review95233 ----------------------------------------------------------- On May 5, 2016, 12:23 a.m., Michael Pyne wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127837/ > ----------------------------------------------------------- > > (Updated May 5, 2016, 12:23 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: oxygen > > > Description > ------- > > oxygen windeco: Fix use-after-free for pixmap in QCache. > > Coverity identified (in CID 1336171) a usage of QPixmap after it's been > the parameter to QCache<QPixmap>::insert. > > This is unsafe since QCache gains ownership of whatever object is passed > in, and can even (at least in theory) delete the object you pass in. > Instead give the QCache its own copy of the pixmap. > > To make this work without leaking our existing pixmap we need to work > with a QPixmap instead of QPixmap* in the non-cached case. This leads to > whitespace changes; use git diff -b to filter pure whitespace changes > out. > > > Diffs > ----- > > kdecoration/oxygendecohelper.cpp a7e9306 > > Diff: https://git.reviewboard.kde.org/r/127837/diff/ > > > Testing > ------- > > The new code compiles but I'm currently unable to test since kcmshell5 > kwindecoration (and any other KCM viewer) is currently crashing for me in > QML, due to what I'm sure is a local misconfiguration... > > > Thanks, > > Michael Pyne > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
